flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...
Date Fri, 24 Nov 2017 10:28:50 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5058
  
    I would like to make a few comments for followup:
    
      - I think `TimerServiceOptions` should not be an own class, we are getting a crazy fragmentation
of options into classes (that have sometimes, like here, only one option defined). Let's merge
these into the `TaskManagerOptions`.
    
      - The config key does not reflect the scheme in which all other config keys are defined.
It reads like a name where the dot '.' is a work separator. The scheme in which all other
config keys are defined is hierarchical, like a path in a nested config group/object structure.
Think that the configuration is one huge JSON object, and the key is the dot path to the entry.
Hence a key like `taskmanager.timers.shutdown-timeout` (or `taskmanager.timers.shutdown.timeout`,
if we view `shutdown` as a full config group/object) would be in line with the resulting style.



---

Mime
View raw message