flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #5065: [FLINK-8139][table] Check for proper equals() and hashCod...
Date Fri, 24 Nov 2017 12:45:05 GMT
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/5065
  
    Hi @Aegeaner, thanks for the pull request. 
    I had a brief look at it and noticed a few things:
    
    1. Please fill out the PR template (see #5063 as an example)
    2. Please add unit tests that validate that the checks you added are working correctly.

    3. Please update the `equals()` and `hashCode()` methods of `Row` as mentioned in the
JIRA issue.
    
    Thank you, Fabian


---

Mime
View raw message