flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5068: [FLINK-8122] [table] Name all built-in table sinks...
Date Mon, 27 Nov 2017 09:41:12 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5068#discussion_r153145672
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
    @@ -60,4 +60,14 @@ trait TableSource[T] {
         */
       def explainSource(): String = ""
     
    +  /**
    +    * Gets the name which is used by the visualization and logging during runtime.
    +    *
    +    * @return Name of the [[TableSource]].
    +    */
    +  def getRuntimeName(): String = {
    --- End diff --
    
    I would like to avoid changing the `TableSource` interface again. I think we can use `explainSource`
instead.


---

Mime
View raw message