flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...
Date Wed, 29 Nov 2017 11:26:29 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5092#discussion_r153760748
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSourceContexts.java
---
    @@ -313,6 +325,7 @@ protected void processAndCollectWithTimestamp(T element, long timestamp)
{
     		@Override
     		protected void processAndEmitWatermark(Watermark mark) {
     			output.emitWatermark(mark);
    +			watermarkGauge.setCurrentLowWatermark(mark.getTimestamp());
    --- End diff --
    
    Yes, for the `AutomaticWatermarkContext` we still need some specific update logic in there
for the periodic watermarks.
    
    But we should still be able to migrate https://github.com/apache/flink/pull/5092/files/e2b20ee95ca66cbf42c7f3295863bc95605b4521#diff-e38689efd0a97938646aa97eb8a97d96R328
and the missing update after https://github.com/apache/flink/pull/5092/files#diff-e38689efd0a97938646aa97eb8a97d96R215
to the base class, no?



---

Mime
View raw message