flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...
Date Wed, 29 Nov 2017 14:49:49 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5040#discussion_r153806967
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/utils/RowTypeTestBase.scala
---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.expressions.utils
    +
    +import java.sql.Date
    +
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.java.typeutils.{ObjectArrayTypeInfo, RowTypeInfo}
    +import org.apache.flink.table.api.Types
    +import org.apache.flink.types.Row
    +
    +class RowTypeTestBase extends ExpressionTestBase {
    --- End diff --
    
    I think we don't need a `TestBase` class if there is only one class extending it.


---

Mime
View raw message