flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...
Date Wed, 29 Nov 2017 14:49:49 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5040#discussion_r153802956
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
    @@ -1308,6 +1313,19 @@ abstract class CodeGenerator(
         }
       }
     
    +  private[flink] def generateBoxedElementWithNullableSupport(
    +      element: GeneratedExpression,
    +      boxedTypeTerm: String)
    --- End diff --
    
    This should be a parameter with TypeInformation type.


---

Mime
View raw message