flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...
Date Thu, 30 Nov 2017 16:16:31 GMT
Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5099#discussion_r154122694
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java ---
    @@ -25,20 +25,9 @@
     public class MetricOptions {
     
     	/**
    -	 * The list of named reporters. Names are defined here and per-reporter configs
    -	 * are given with the reporter config prefix and the reporter name.
    -	 *
    -	 * Example:
    -	 * <pre>{@code
    -	 * metrics.reporters = foo, bar
    -	 *
    -	 * metrics.reporter.foo.class = org.apache.flink.metrics.reporter.JMXReporter
    -	 * metrics.reporter.foo.interval = 10
    -	 *
    -	 * metrics.reporter.bar.class = org.apache.flink.metrics.graphite.GraphiteReporter
    -	 * metrics.reporter.bar.port = 1337
    -	 * }</pre>
    +	 * @deprecated This configuration key has no effect.
     	 */
    +	@Deprecated
    --- End diff --
    
    Have we removed all usages of this key? Can we simply delete the option? The behavior
of any reporters relying on this field will be broken so is it better to change the `@PublicEvolving`
API?


---

Mime
View raw message