flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators
Date Wed, 29 Nov 2017 10:02:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270522#comment-16270522
] 

ASF GitHub Bot commented on FLINK-4812:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5092#discussion_r153737987
  
    --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorTest.java
---
    @@ -224,6 +226,39 @@ public void testLatencyMarkEmission() throws Exception {
     		Assert.assertTrue(output.get(i).isWatermark());
     	}
     
    +	@Test
    +	public void testManualWatermarkContextWatermarkMetric() throws Exception {
    --- End diff --
    
    Probably should add verifying the metric value after emitting the `Long.MAX_VALUE` watermark
to this test, just to be on the safe side.


> Report Watermark metrics in all operators
> -----------------------------------------
>
>                 Key: FLINK-4812
>                 URL: https://issues.apache.org/jira/browse/FLINK-4812
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> As reported by a user, Flink does currently not export the current low watermark for
sources (http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/currentLowWatermark-metric-not-reported-for-all-tasks-td13770.html).
> This JIRA is for adding such a metric for the sources as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message