flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators
Date Wed, 29 Nov 2017 15:52:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270976#comment-16270976
] 

ASF GitHub Bot commented on FLINK-4812:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5100
  
    the coupling of input to output gauge becomes rather tricky. The input gauge must be reachable
in `Stream[Two]InputProcessor`, `OperatorChain#createChainedOperator`, and the output gauge
in `AbstractStreamOperator#setup`.
    
    For sources, sinks and watermark assigners we must refer to the same gauge in both places.
I don't see how we can do this in a nice way.
    
    The rather nice thing the current approach has is that everything is contained in `AbstractStreamOperator`
and isn't scattered all over the place.
    
    `Given that we allow people to completely re-define how operators handle watermarks, wouldn't
it make sense to give them the same freedom when it comes to the input watermark metrics?
    



> Report Watermark metrics in all operators
> -----------------------------------------
>
>                 Key: FLINK-4812
>                 URL: https://issues.apache.org/jira/browse/FLINK-4812
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> As reported by a user, Flink does currently not export the current low watermark for
sources (http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/currentLowWatermark-metric-not-reported-for-all-tasks-td13770.html).
> This JIRA is for adding such a metric for the sources as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message