flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6094) Implement stream-stream proctime non-window inner join
Date Thu, 23 Nov 2017 16:02:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264528#comment-16264528
] 

ASF GitHub Bot commented on FLINK-6094:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4471#discussion_r152825553
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/UpdatingPlanChecker.scala
---
    @@ -116,14 +135,100 @@ object UpdatingPlanChecker {
               val windowStartEnd = w.getWindowProperties.map(_.name)
               // we have only a unique key if at least one window property is selected
               if (windowStartEnd.nonEmpty) {
    -            keys = Some(groupKeys ++ windowStartEnd)
    +            val smallestAttribute = windowStartEnd.sorted.head
    --- End diff --
    
    Replace with `windowStartEnd.min`. Can you explain this logic? Selecting only the first
string looks a bit weird.


> Implement stream-stream proctime non-window  inner join
> -------------------------------------------------------
>
>                 Key: FLINK-6094
>                 URL: https://issues.apache.org/jira/browse/FLINK-6094
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Hequn Cheng
>
> This includes:
> 1.Implement stream-stream proctime non-window  inner join
> 2.Implement the retract process logic for join



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message