flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based
Date Fri, 24 Nov 2017 13:45:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265296#comment-16265296
] 

ASF GitHub Bot commented on FLINK-7406:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4509#discussion_r152962580
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
    @@ -330,64 +332,120 @@ public void testRequestAndReturnFloatingBuffer() throws Exception
{
     			// Prepare the exclusive and floating buffers to verify recycle logic later
     			Buffer exclusiveBuffer = inputChannel.requestBuffer();
     			assertNotNull(exclusiveBuffer);
    -			Buffer floatingBuffer1 = bufferPool.requestBuffer();
    -			assertNotNull(floatingBuffer1);
    -			Buffer floatingBuffer2 = bufferPool.requestBuffer();
    -			assertNotNull(floatingBuffer2);
    +
    +			final int numRecycleFloatingBuffers = 4;
    +			final ArrayDeque<Buffer> floatingBufferQueue = new ArrayDeque<>(numRecycleFloatingBuffers);
    +			for (int i = 0; i < numRecycleFloatingBuffers; i++) {
    +				Buffer floatingBuffer = bufferPool.requestBuffer();
    +				assertNotNull(floatingBuffer);
    +				floatingBufferQueue.add(floatingBuffer);
    +			}
    --- End diff --
    
    if you add `verify(bufferPool, times(4)).requestBuffer();` here, the difference to the
13 below becomes a bit more clear (because the requests are absolute values while as differences
would be clear from the start, i.e. that we request 9 additional buffers - unfortunately,
Mockito does not provide this as far as I know - but that's not a big deal as soon as everything
is clear)


> Implement Netty receiver incoming pipeline for credit-based
> -----------------------------------------------------------
>
>                 Key: FLINK-7406
>                 URL: https://issues.apache.org/jira/browse/FLINK-7406
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> Currently {{PartitionRequestClientHandler}} receives and reads {{BufferResponse}} from
producer. It will request buffer from {{BufferPool}} for holding the message. If not got,
the message is staged temporarily and {{autoread}} for channel is set false.
> For credit-based mode, {{PartitionRequestClientHandler}} can always get buffer from {{RemoteInputChannel}}
for reading messages from producer.
> The related works are:
> * Add the backlog of producer in {{BufferResponse}} message structure
> * {{PartitionRequestClientHandler}} requests buffer from {{RemoteInputChannel}} directly
> * {{PartitionRequestClientHandler}} updates backlog for {{RemoteInputChannel}}, and it
may trigger requests of floating buffers from {{BufferPool}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message