flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7420) Move all Avro code to flink-avro
Date Fri, 03 Nov 2017 14:04:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237632#comment-16237632
] 

ASF GitHub Bot commented on FLINK-7420:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4942#discussion_r148789659
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/KryoRegistrationSerializerConfigSnapshot.java
---
    @@ -217,7 +217,7 @@ public void read(DataInputView in) throws IOException {
     	/**
     	 * Placeholder dummy for a previously registered class that can no longer be found in
classpath on restore.
     	 */
    -	public static class DummyRegisteredClass {}
    +	public static class DummyRegisteredClass implements Serializable {}
    --- End diff --
    
    `serialVersionUID` is missing.


> Move all Avro code to flink-avro
> --------------------------------
>
>                 Key: FLINK-7420
>                 URL: https://issues.apache.org/jira/browse/FLINK-7420
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.4.0
>
>
> *Problem*
> Currently, the {{flink-avro}} project is a shell with some tests and mostly duplicate
and dead code. The classes that use Avro are distributed quite wildly through the code base,
and introduce multiple direct dependencies on Avro in a messy way.
> That way, we cannot create a proper fat Avro dependency in which we shade Jackson away.
> Also, we expose Avro as a direct and hard dependency on many Flink modules, while it
should be a dependency that users that use Avro types selectively add.
> *Suggested Changes*
> We should move all Avro related classes to {{flink-avro}}, and give {{flink-avro}} a
dependency on {{flink-core}} and {{flink-streaming-java}}.
>   - {{AvroTypeInfo}}
>   - {{AvroSerializer}}
>   - {{AvroRowSerializationSchema}}
>   - {{AvroRowDeserializationSchema}}
> To be able to move the the avro serialization code from {{flink-ore}} to {{flink-avro}},
we need to load the {{AvroTypeInformation}} reflectively, similar to how we load the {{WritableTypeInfo}}
for Hadoop.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message