flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Che Wei (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7692) Support user-defined variables in Metrics
Date Wed, 29 Nov 2017 01:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269921#comment-16269921

Wei-Che Wei commented on FLINK-7692:

This idea is much better. I would like to keep working on it based on your scaffold.
One more thing needs to be confirmed: I need to distinguish when to add {{GenericKeyMetricGroup}}
or {{GenericMetricGroup}} if a group {{name}} doesn't exist, since it will always create {{GenericKeyMetricGroup}}
in your scaffold. Am I right?

> Support user-defined variables in Metrics
> -----------------------------------------
>                 Key: FLINK-7692
>                 URL: https://issues.apache.org/jira/browse/FLINK-7692
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Wei-Che Wei
>            Priority: Minor
>             Fix For: 1.5.0
> Reporters that identify metrics with a set of key-value pairs are currently limited to
the variables defined by Flink, like the taskmanager ID, with users not being able to supply
their own.
> This is inconsistent with reporters that use metric identifiers that freely include user-defined
groups constructted via {{MetricGroup#addGroup(String name)}}.
> I propose adding a new method {{MetricGroup#addGroup(String key, String name)}} that
adds a new key-value pair to the {{variables}} map in it's constructor. When constructing
the metric identifier the key should be included as well, resulting in the same result as
when constructing the metric groups tree via {{group.addGroup(key).addGroup(value)}}.
> For this a new {{KeyedGenericMetricGroup}} should be created that resembles the unkeyed
version, with slight modifications to the constructor and {{getScopeComponents}} method.

This message was sent by Atlassian JIRA

View raw message