flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7762) Make WikipediaEditsSourceTest a proper test
Date Wed, 29 Nov 2017 17:12:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271127#comment-16271127
] 

ASF GitHub Bot commented on FLINK-7762:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5102
  
    The changes look good! But you comment about needing that IRC channel seem valid. If we
don't have the test, however, we would have no way of knowing that the code at least works.
(We could also drop the source completely)


> Make WikipediaEditsSourceTest a proper test
> -------------------------------------------
>
>                 Key: FLINK-7762
>                 URL: https://issues.apache.org/jira/browse/FLINK-7762
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming Connectors
>            Reporter: Aljoscha Krettek
>            Assignee: Ufuk Celebi
>            Priority: Minor
>
> {{WikipediaEditsSourceTest}} is currently an ITCase even though it's called test. Making
it a test reduces runtime and also makes it more stable because we don't run a whole Flink
job.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message