flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7907) Flink Metrics documentation missing Scala examples
Date Sun, 26 Nov 2017 09:55:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265954#comment-16265954
] 

ASF GitHub Bot commented on FLINK-7907:
---------------------------------------

GitHub user yew1eb opened a pull request:

    https://github.com/apache/flink/pull/5071

    [FLINK-7907][docs] The metrics documentation missing scala snippets

    ## What is the purpose of the change
    
    *The metrics documentation is missing Scala examples for many of the metrics types. To
be consistent there should be Scala examples for all the types.*
    
    ## Brief change log
    
      - *Add scala snippets for  `Counter` , `Histogram `, `Meter` types of metrics*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yew1eb/flink FLINK-7907

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5071.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5071
    
----
commit 839c368f6b3f7a132ab4aa5b592ebdbc51f5b498
Author: yew1eb <yew1eb@gmail.com>
Date:   2017-11-26T09:44:38Z

    [FLINK-7907][docs] Update metrics docs to include Scala snippets

----


> Flink Metrics documentation missing Scala examples
> --------------------------------------------------
>
>                 Key: FLINK-7907
>                 URL: https://issues.apache.org/jira/browse/FLINK-7907
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Colin Williams
>            Assignee: Hai Zhou UTC+8
>            Priority: Minor
>
> The Flink metrics documentation is missing Scala examples for many of the metrics types.
To be consistent there should be Scala examples for all the types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message