flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7971) Fix potential NPE with inconsistent state
Date Fri, 03 Nov 2017 08:26:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237259#comment-16237259
] 

ASF GitHub Bot commented on FLINK-7971:
---------------------------------------

GitHub user Xpray opened a pull request:

    https://github.com/apache/flink/pull/4941

    [FLINK-7971][TableAPI & SQL] Fix potential NPE with inconsistent state

    
    ## What is the purpose of the change
    
    fix potential NPE with inconsistent state
    
    
    ## Brief change log
    
      -  the `cntState`  is independent from `state` , they shall be treated separately.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage. 
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency):  no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive):  no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper:  no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-7971

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4941
    
----
commit 428de1f7833d265fc36e3ff5d163dab73409c425
Author: Xpray <leonxpray@gmail.com>
Date:   2017-11-03T07:19:42Z

    [FLINK-7971][TableAPI & SQL] Fix potential NPE with inconsistent state

----


> Fix potential NPE with inconsistent state
> -----------------------------------------
>
>                 Key: FLINK-7971
>                 URL: https://issues.apache.org/jira/browse/FLINK-7971
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Major
>
> In {{GroupAggProcessFunction}}, the status of  {{state}} and {{cntState}} are not consistent,
which may cause NPE when {{state}} is not null but {{cntState}} is null.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message