flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7979) Use Log.*(Object, Throwable) overload to log exceptions
Date Mon, 06 Nov 2017 13:37:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240300#comment-16240300

ASF GitHub Bot commented on FLINK-7979:

Github user StephanEwen commented on the issue:

    Sorry, I am opposed to changing that.
    Sometimes an author explicitly wants to append parts of the parent exception message to
make it easier to navigate exception stack traces. I think we should let authors do that when
they think it helps making exceptions more understandable.

> Use Log.*(Object, Throwable) overload to log exceptions
> -------------------------------------------------------
>                 Key: FLINK-7979
>                 URL: https://issues.apache.org/jira/browse/FLINK-7979
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Hai Zhou UTC+8
>            Assignee: Hai Zhou UTC+8
>            Priority: Critical
>             Fix For: 1.5.0
> I found some code that logging an exception, through convert the exception to string
or call .getMessage. {{.getMessage()}}.
> I think the better way is to use the Logger method overloads which take {{`Throwable`}}
as a parameter.

This message was sent by Atlassian JIRA

View raw message