flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7996) Add support for (left.time = right.time) predicates to window join.
Date Wed, 08 Nov 2017 02:30:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243292#comment-16243292
] 

ASF GitHub Bot commented on FLINK-7996:
---------------------------------------

GitHub user xccui opened a pull request:

    https://github.com/apache/flink/pull/4977

    [FLINK-7996] [table] Add support for (left.time = right.time) predicates to window join

    ## What is the purpose of the change
    
    This PR adds `left.time = right.time` predicates support for time-windowed join in Table
API and SQL.
    
    ## Brief change log
    
      - Change `WindowJoinUtil.extractWindowBoundsFromPredicate()` to accept single euqi-time
predicate.
      - Add tests for the new predicate.
      - Update the documents.
    
    ## Verifying this change
    
    This change can be verified by the added tests in `JoinTest` and `JoinITCase`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (yes / no / don't know)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (docs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xccui/flink FLINK-7996

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4977.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4977
    
----
commit 03d54c672f4a529c1cf0e3af3e74d60fb37febb7
Author: Xingcan Cui <xingcanc@gmail.com>
Date:   2017-11-07T17:17:57Z

    [FLINK-7996][table]Add support for (left.time = right.time) predicates to window join

----


> Add support for (left.time = right.time) predicates to window join.
> -------------------------------------------------------------------
>
>                 Key: FLINK-7996
>                 URL: https://issues.apache.org/jira/browse/FLINK-7996
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Xingcan Cui
>            Priority: Critical
>             Fix For: 1.4.0
>
>
> A common operation is to join the result of two window aggregations on the same timestamp.

> However, window joins do not support equality predicates on time attributes such as {{left.time
= right.time}} but require two range predicates such as {{left.time >= right.time AND left.time
<= right.time}}.
> This can be fixed in the translation code (the operator does not have to be touched).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message