flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7998) Make case classes in TPCHQuery3.java public to allow dynamic instantiation
Date Wed, 08 Nov 2017 01:32:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243230#comment-16243230
] 

ASF GitHub Bot commented on FLINK-7998:
---------------------------------------

Github user naeioi commented on the issue:

    https://github.com/apache/flink/pull/4959
  
    Also can you replace `params.get("order")` with `params.get("orders")` in TPCHQuery3.scala
for consistency with java and the input hint?


> Make case classes in TPCHQuery3.java public to allow dynamic instantiation
> --------------------------------------------------------------------------
>
>                 Key: FLINK-7998
>                 URL: https://issues.apache.org/jira/browse/FLINK-7998
>             Project: Flink
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 1.3.2
>            Reporter: Keren Zhu
>            Priority: Minor
>              Labels: easyfix
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Case classes Lineitem, Customer and Order in example TPCHQuery3.java are set to private.
This causes an IllegalAccessException exception because of reflection check in dynamic class
instantiation. Making them public resolves the problem (which is what implicitly suggested
by _case class_ in TPCHQuery3.scala)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message