flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8063) Client blocks indefinitely when querying a non-existing state
Date Wed, 15 Nov 2017 13:47:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253459#comment-16253459
] 

ASF GitHub Bot commented on FLINK-8063:
---------------------------------------

GitHub user kl0u opened a pull request:

    https://github.com/apache/flink/pull/5021

    [FLINK-8063][QS] QS client does not retry when an UnknownKvStateLocation.

    ## What is the purpose of the change
    
    Fix bug in QS client. Before if the client submitted a query with invalid queryable state
 name, it would retry the query indefinitely. This change fixes it.
    
    ## Brief change log
    
    The change is in the `KvStateClientProxyHandler` where we change the conditions based
on which we automatically retry a query.
    
    ## Verifying this change
    
    Adds test `AbstractQueryableStateTestBase.testWrongQueryableStateName()`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kl0u/flink qs-8063-client-blocking

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5021
    
----
commit d4f4a17bf6af98fdf4e2f362e9b20d1998e74110
Author: kkloudas <kkloudas@gmail.com>
Date:   2017-11-14T14:05:45Z

    [FLINK-8063][QS] QS client does not retry when an UnknownKvStateLocation is thrown.

----


> Client blocks indefinitely when querying a non-existing state
> -------------------------------------------------------------
>
>                 Key: FLINK-8063
>                 URL: https://issues.apache.org/jira/browse/FLINK-8063
>             Project: Flink
>          Issue Type: Improvement
>          Components: Queryable State
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Kostas Kloudas
>            Priority: Critical
>             Fix For: 1.4.0
>
>
> When querying for a non-existing state (as in, no state was registered under queryableStateName)
the client blocks indefinitely.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message