flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8070) YarnTestBase should print prohibited string
Date Tue, 21 Nov 2017 20:37:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261448#comment-16261448
] 

ASF GitHub Bot commented on FLINK-8070:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/5012
  
    LGTM. I'm puzzled why the `])` is printed out-of-order in the middle of the stack trace.


> YarnTestBase should print prohibited string
> -------------------------------------------
>
>                 Key: FLINK-8070
>                 URL: https://issues.apache.org/jira/browse/FLINK-8070
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests, YARN
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Critical
>
> The yarn tests check the log files for a set of prohibited strings. If found, the entire
log file is logged as WARN, the offending line is logged as ERROR, and the test fails with
this unhelpful message:
> {code}
> java.lang.AssertionError(Found a file /home/travis/build/apache/flink/flink-yarn-tests/target/flink-yarn-tests-fifo/flink-yarn-tests-fifo-logDir-nm-1_0/application_1510164935122_0002/container_1510164935122_0002_01_000001/jobmanager.log
with a prohibited string: [Exception, Started SelectChannelConnector@0.0.0.0:8081])
> {code}
> If you don't have log access on travis you have thus no knowledge what actually went
wrong.
> I propose to also print smaller excerpts around the found error (like 10 lines or smth)
in the Assert.fail message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message