flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8080) Remove need for "metrics.reporters"
Date Thu, 30 Nov 2017 16:17:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272879#comment-16272879
] 

ASF GitHub Bot commented on FLINK-8080:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5099#discussion_r154121821
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
    @@ -43,8 +46,8 @@
     
     	private static volatile MetricRegistryConfiguration defaultConfiguration;
     
    -	// regex pattern to split the defined reporters
    -	private static final Pattern splitPattern = Pattern.compile("\\s*,\\s*");
    +	// regex pattern to extract the name from reporter configuration keys, e.g. "rep" from
"metrics.reporter.rep.class"
    +	private static final Pattern configurationPattern = Pattern.compile("metrics\\.reporter\\.([\\S&&[^.]]*)\\..*");
    --- End diff --
    
    Can we `Pattern.quote(ConfigConstants.METRICS_REPORTER_PREFIX)`?


> Remove need for "metrics.reporters"
> -----------------------------------
>
>                 Key: FLINK-8080
>                 URL: https://issues.apache.org/jira/browse/FLINK-8080
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration, Metrics
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.5.0
>
>
> Currently, in order to use a reporter one must configure something like this:
> {code}
> metrics.reporters: jmx
> metrics.reporter.jmx.class: ...
> {code}
> It would be neat if users did not have to set {{metrics.reporters}}. We can accomplish
this by a scanning the configuration for configuration keys starting with {{metrics.reporter.}}
and using the next word as a reporter name.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message