flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8104) Fix Row value constructor
Date Wed, 29 Nov 2017 14:50:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270882#comment-16270882
] 

ASF GitHub Bot commented on FLINK-8104:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5040#discussion_r153807597
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/CalcITCase.scala
---
    @@ -308,6 +308,27 @@ class CalcITCase(
         TestBaseUtils.compareResultAsText(results.asJava, expected)
       }
     
    +  @Test
    +  def testValueConstructor(): Unit = {
    +    val env = ExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env, config)
    +
    +    val sqlQuery = "SELECT (a, b, c), ARRAY[b, b] FROM MyTable"
    +
    +    val ds = env.fromElements((
    +      "foo",
    +      12,
    +      Timestamp.valueOf("1984-07-12 14:34:24")))
    +    tEnv.registerDataSet("MyTable", ds, 'a, 'b, 'c)
    +
    +    val result = tEnv.sqlQuery(sqlQuery)
    +
    +    val expected = "foo,12,1984-07-12 14:34:24.0,[12, 12]"
    +    val results = result.toDataSet[Row].collect()
    --- End diff --
    
    Can you test the real objects instead of the strings? To make sure that row has not been
flattened by Calcite.


> Fix Row value constructor
> -------------------------
>
>                 Key: FLINK-8104
>                 URL: https://issues.apache.org/jira/browse/FLINK-8104
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>
> Support Row value constructor which is currently broken. 
> See 
> {code:java}
> // flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/SqlExpressionTest.scala
>   @Test
>   def testValueConstructorFunctions(): Unit = {
>     // TODO we need a special code path that flattens ROW types
>     // testSqlApi("ROW('hello world', 12)", "hello world") // test base only returns
field 0
>     // testSqlApi("('hello world', 12)", "hello world") // test base only returns field
0
>     // ...
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message