flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8104) Fix Row value constructor
Date Thu, 30 Nov 2017 19:46:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273280#comment-16273280
] 

ASF GitHub Bot commented on FLINK-8104:
---------------------------------------

Github user walterddr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5040#discussion_r154179674
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/utils/RowTypeTestBase.scala
---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.expressions.utils
    +
    +import java.sql.Date
    +
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.java.typeutils.{ObjectArrayTypeInfo, RowTypeInfo}
    +import org.apache.flink.table.api.Types
    +import org.apache.flink.types.Row
    +
    +class RowTypeTestBase extends ExpressionTestBase {
    --- End diff --
    
    Forgot to add `RowTypeValidationTest` in previous diff actually


> Fix Row value constructor
> -------------------------
>
>                 Key: FLINK-8104
>                 URL: https://issues.apache.org/jira/browse/FLINK-8104
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>
> Support Row value constructor which is currently broken. 
> See 
> {code:java}
> // flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/SqlExpressionTest.scala
>   @Test
>   def testValueConstructorFunctions(): Unit = {
>     // TODO we need a special code path that flattens ROW types
>     // testSqlApi("ROW('hello world', 12)", "hello world") // test base only returns
field 0
>     // testSqlApi("('hello world', 12)", "hello world") // test base only returns field
0
>     // ...
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message