flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8126) Update and fix checkstyle
Date Tue, 21 Nov 2017 21:48:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261538#comment-16261538
] 

ASF GitHub Bot commented on FLINK-8126:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/5044

    [FLINK-8126] [build] Fix and update checkstyle

    ## What is the purpose of the change
    
    Update to the latest checkstyle version and fix the errors not previously detected.
    
    ## Brief change log
    
    - update checkstyle to version 8.4 from version 6.19
    - in `checkstyle.xml` move `SuppressionCommentFilter` under `TreeWalker` and remove `FileContentsHolder`
(see checkstyle/checkstyle pr4714)
    - correct latent checkstyle errors
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 8126_update_and_fix_checkstyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5044.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5044
    
----
commit 3a01732d4e823f732f5fa4b63054b4b8f9e40f3e
Author: Greg Hogan <code@greghogan.com>
Date:   2017-11-21T19:05:53Z

    [FLINK-8126] [build] Fix and update checkstyle
    
    Update to the latest checkstyle version and fix the errors not
    previously detected.

----


> Update and fix checkstyle
> -------------------------
>
>                 Key: FLINK-8126
>                 URL: https://issues.apache.org/jira/browse/FLINK-8126
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.5.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Trivial
>             Fix For: 1.5.0
>
>
> Our current checkstyle configuration (checkstyle version 6.19) is missing some ImportOrder
and variable naming errors which are detected in 1) IntelliJ using the same checkstyle version
and 2) with the maven-checkstyle-plugin with an up-to-date checkstyle version (8.4).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message