flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table
Date Sat, 25 Nov 2017 13:05:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265708#comment-16265708
] 

ASF GitHub Bot commented on FLINK-8139:
---------------------------------------

Github user Aegeaner commented on the issue:

    https://github.com/apache/flink/pull/5065
  
    Hi @fhueske , thanks for review. 
    I will update` equals() `and `hashcode() `methods of Row, but I also noticed that in `JoinOperator`
and `KeySelector`, they used `RowComparator` to compare row elements. 
    For the unit test, I noticed in `TypeInformationTestBase` there is a` testHashcodeAndEquals`
method already, I will complete this test to add test case with type info without implementing
its own `hashcode ` and `equals` method.


> Check for proper equals() and hashCode() when registering a table
> -----------------------------------------------------------------
>
>                 Key: FLINK-8139
>                 URL: https://issues.apache.org/jira/browse/FLINK-8139
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Aegeaner
>
> In the current Table API & SQL implementation we compare {{Row}}s at different positions.
E.g., for joining we test rows for equality or put them into state. A heap state backend requires
proper hashCode() and equals() in order to work correct. Thus, every type in the Table API
needs to have these methods implemented.
> We need to check if all fields of a row have implement methods that differ from {{Object.equals()}}
and {{Object.hashCode()}} via reflections. Both coming from TableSource and DataStream/DataSet.
> Additionally, for array types, the {{Row}} class should use {{Arrays.deepEquals()}} and
{{Arrays.deepHashCode()}} instead of the non-deep variants.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message