flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8148) Test instability in YarnFileStageTest
Date Fri, 24 Nov 2017 13:59:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265301#comment-16265301
] 

ASF GitHub Bot commented on FLINK-8148:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5066

    [FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase

    ## What is the purpose of the change
    
    `YarnFileStageTestS3ITCase.testRecursiveUploadForYarn` verifies that the test directory
used is cleaned up by `YarnFileStageTest.testCopyFromLocalRecursive` which should clean up
the directory (in a `finally` block). However, for S3, we may not always see our own deletes.
    
    Quoting from https://aws.amazon.com/s3/faqs/ here:
    
    > Q: What data consistency model does Amazon S3 employ?
    > Amazon S3 buckets in all Regions provide read-after-write consistency for PUTS of
new objects and eventual consistency for overwrite PUTS and DELETES.
    
    ## Brief change log
    
    - Remove a check for a deleted directory since we may not see our own delete yet
    with S3.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-8148

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5066.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5066
    
----
commit 29d7a8e085a5655c00a3163546e22a5d1331ea60
Author: Nico Kruber <nico@data-artisans.com>
Date:   2017-11-24T13:54:41Z

    [FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase
    
    Remove a check for a deleted directory since we may not see our own delete yet
    with S3.

----


> Test instability in YarnFileStageTest
> -------------------------------------
>
>                 Key: FLINK-8148
>                 URL: https://issues.apache.org/jira/browse/FLINK-8148
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests, YARN
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Critical
>              Labels: test-stability
>
> {code}
> Running org.apache.flink.yarn.YarnFileStageTestS3ITCase
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 13.152 sec <<<
FAILURE! - in org.apache.flink.yarn.YarnFileStageTestS3ITCase
> testRecursiveUploadForYarnS3(org.apache.flink.yarn.YarnFileStageTestS3ITCase)  Time elapsed:
8.515 sec  <<< FAILURE!
> java.lang.AssertionError: null
> 	at org.junit.Assert.fail(Assert.java:86)
> 	at org.junit.Assert.assertTrue(Assert.java:41)
> 	at org.junit.Assert.assertFalse(Assert.java:64)
> 	at org.junit.Assert.assertFalse(Assert.java:74)
> 	at org.apache.flink.yarn.YarnFileStageTestS3ITCase.testRecursiveUploadForYarn(YarnFileStageTestS3ITCase.java:171)
> 	at org.apache.flink.yarn.YarnFileStageTestS3ITCase.testRecursiveUploadForYarnS3(YarnFileStageTestS3ITCase.java:192)
> {code}
> from https://travis-ci.org/apache/flink/jobs/305861539
> {{YarnFileStageTestS3ITCase.testRecursiveUploadForYarn}} verifies that the test directory
used is cleaned up by {{YarnFileStageTest.testCopyFromLocalRecursive}} which should clean
up the directory (in a {{finally}} block). However, for S3, we may not always see our own
deletes.
> Quoting from https://aws.amazon.com/s3/faqs/ here:
> {quote}Q: What data consistency model does Amazon S3 employ?
> Amazon S3 buckets in all Regions provide read-after-write consistency for PUTS of new
objects and eventual consistency for overwrite PUTS and DELETES.{quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message