flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8165) ParameterTools not serializable properly
Date Wed, 29 Nov 2017 09:35:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270477#comment-16270477

ASF GitHub Bot commented on FLINK-8165:

GitHub user gyfora opened a pull request:


    [FLINK-8165] ParameterTool serialization fix

    *Thank you very much for contributing to Apache Flink - we are happy that you want to
help us improve Flink. To help the community review your contribution in the best possible
way, please go through the checklist below, which will get the contribution into a shape in
which it can be best reviewed.*
    *Please understand that we do not do this to make contributions to Flink a hassle. In
order to uphold a high standard of quality for code contributions, while at the same time
managing a large number of contributions, we need contributors to prepare the contributions
well, and give reviewers enough contextual information for the review. Please also understand
that contributions that do not follow this guide will take longer to review and thus typically
be picked up with lower priority by the community.*
    ## Contribution Checklist
      - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues).
Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
      - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request",
where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you
are unsure about which is the best component.
      Typo fixes that have no associated JIRA issue should be named following this pattern:
`[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc
for PuncuatedWatermarkGenerator`.
      - Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
      - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
      - Each pull request should address only one issue, not mix up code from multiple issues.
      - Each commit in the pull request has a meaningful commit message (including the JIRA
      - Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
    **(The sections below can be removed for hotfixes of typos)**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gyfora/flink release-1.4

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5096
commit 4b1921aefe871f18b35bab00a7e3acdb74d29593
Author: Gyula Fora <gyfora@apache.org>
Date:   2017-11-29T09:28:50Z

    [FLINK-8165] ParameterTool serialization fix


> ParameterTools not serializable properly
> ----------------------------------------
>                 Key: FLINK-8165
>                 URL: https://issues.apache.org/jira/browse/FLINK-8165
>             Project: Flink
>          Issue Type: Bug
>          Components: Configuration, Java API
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Gyula Fora
>            Priority: Critical
> Trying to get with default value after deserialization fails as the EmptyMap doesn't
support put operations for new default values.
> The problem is here:
> https://github.com/apache/flink/blob/release-1.4.0-rc2/flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java#L621
> Reproduce:
> {code}
> 	@Test
> 	public void tes() throws IOException, ClassNotFoundException {
> 		ParameterTool params = ParameterTool.fromMap(new HashMap<>());
>                 // works
> 		params.get("asd", "default");
> 		byte[] b = InstantiationUtil.serializeObject(params);
> 		ParameterTool dparams = InstantiationUtil.deserializeObject(b, getClass().getClassLoader());
>                  // fails
> 		dparams.get("asd", "default");
> 	}
> {code}

This message was sent by Atlassian JIRA

View raw message