flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4957: [FLINK-7773] [tests] Move all mocking before testi...
Date Mon, 06 Nov 2017 16:08:57 GMT
GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4957

    [FLINK-7773] [tests] Move all mocking before testing code in UtilsTest to avoid unfinished
stubbing

    ## What is the purpose of the change
    
    Move all mocking code before the actual testing code in UtilsTest#testYarnFlinkResourceManagerJobManagerLostLeadership.
    Hopefully, this will fix the unfinished stubbing exception which still occurs spuriously.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink hardenUtilsTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4957
    
----
commit 8c572f943dd064c8d22100ced1e1f50645f6e519
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-11-06T16:07:38Z

    [FLINK-7773] [tests] Move all mocking before testing code in UtilsTest to avoid unfinished
stubbing
    
    Move all mocking code before the actual testing code in UtilsTest#testYarnFlinkResourceManagerJobManagerLostLeadership.
    Hopefully, this will fix the unfinished stubbing exception which still occurs spuriously.

----


---

Mime
View raw message