flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4958: [FLINK-8000] Sort Rest handler URLS in RestServerE...
Date Mon, 06 Nov 2017 17:03:13 GMT
GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4958

    [FLINK-8000] Sort Rest handler URLS in RestServerEndpoint

    ## What is the purpose of the change
    
    Introduce special `RestHandlerUrlComparator` to sort REST URLs such that
    URLs with path parameters are sorted after those without or fewer.
    
    E.g. the following order would be established
    
    ```
    /jobs
    /jobs/overview
    /jobs/:jobid
    /jobs/:jobid/config
    /:*
    ```
    
    ## Brief change log
    
    - Introduce `RestHandlerUrlComparator`
    - Sort list of returned rest handlers in `RestServerEndpoint` before registering them
    
    ## Verifying this change
    
    - `RestServerEndpointTest#testRestHandlerUrlSorting`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink sortRestHandlerUrls

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4958.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4958
    
----
commit d1c436ef0e9e446004e21e3c6be6173d15aba359
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-11-04T13:56:11Z

    [FLINK-8000] Sort Rest handler URLS in RestServerEndpoint
    
    Introduce special RestHandlerUrlComparator to sort REST URLs such that
    URLs with path parameters are sorted after those without or fewer.
    
    E.g. the following order would be established
    
    /jobs
    /jobs/overview
    /jobs/:jobid
    /jobs/:jobid/config
    /:*

----


---

Mime
View raw message