flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4965: [FLINK-8004][metrics][docs] Fix usage examples
Date Tue, 07 Nov 2017 10:44:15 GMT
GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4965

    [FLINK-8004][metrics][docs] Fix usage examples

    ## What is the purpose of the change
    
    This PR fixes several issues in the metric usage examples in the documentation.
    
    ## Brief change log
    * remove wrong `@public` sections with a proper `@Override` a dpublic modifier
    * stream line all examples to just return the input (required adjusting types)
    * added missing return statements
    * modified all examples to override all required methods (open() & map())


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8004

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4965.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4965
    
----
commit 984473a58a70daf09d7d0cc2f409c05d391a4be1
Author: zentol <chesnay@apache.org>
Date:   2017-11-07T10:40:15Z

    [FLINK-8004][metrics][docs] Fix usage examples

----


---

Mime
View raw message