flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5014: [FLINK-8071][build] Bump shade-plugin asm version ...
Date Tue, 14 Nov 2017 15:21:13 GMT
GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5014

    [FLINK-8071][build] Bump shade-plugin asm version to 5.1

    ## What is the purpose of the change
    
    This PR bumps the ASM dependency of the `maven-shade-plugin` to 5.1 as a workaround to
a bug in ASM. This bug causes some error during the shading of akka, making it unusable.
    
    ## Verifying this change
    
    I can't guarantee 100% that this fixes the issue, since the shading issue only manifests
sometimes. This means a simple recompilation of flink-runtime _can_ resolve the issue temporarily.
    
    I've compiled flink-runtime, flink-dist and ran the flink-yarn-tests in a loop and switched
the version bump on and off. It only failed with the old ASM version,
    
    To verify that the `maven-shade-plugin` uses ASM 5.1, run `mvn -X package` in an arbitrary
module and check the dependency tree.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8071

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5014.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5014
    
----
commit 2544cc4078e85673767e8d2ff1a5966f0b07baa7
Author: zentol <chesnay@apache.org>
Date:   2017-11-14T13:47:00Z

    [FLINK-8071][build] Bump shade-plugin asm version to 5.1

----


---

Mime
View raw message