flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5049: [FLINK-8081][metrics] Annotate 'MetricRegistry#get...
Date Wed, 22 Nov 2017 11:05:15 GMT
GitHub user zentol opened a pull request:


    [FLINK-8081][metrics] Annotate 'MetricRegistry#getReporters' with '@V…

    ## What is the purpose of the change
    `MetricRegistry#getReporters()` is only used for testing purposes to provide access to
instantiated reporters. We should annotate this method with `@VisibleForTesting`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8081

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5049
commit 18576da06905c4401bf701e0c09ee4fb44de2ec7
Author: zentol <chesnay@apache.org>
Date:   2017-11-15T12:14:18Z

    [FLINK-8081][metrics] Annotate 'MetricRegistry#getReporters' with '@VisibleForTesting'



View raw message