flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...
Date Wed, 29 Nov 2017 11:57:11 GMT
GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5099

    [FLINK-8080][metrics] Remove need for "metrics.reporters" config key

    ## What is the purpose of the change
    
    This PR simplifies the reporter configuration by no longer requiring users to explicitly
set a list of reporter names via `metrics.reporters`. Instead, the names are automatically
determined based on `metrics.reporter.<name>.<option>` keys found in the configuration.
    
    ## Brief change log
    
    * modify reporter configuration parsing to detect reporter names
    * deprecate `MetricOptions.REPORTERS_LIST`
      * remove all usages
      * remove all references from documentation
    
    ## Verifying this change
    
    This change is already covered by existing tests in the various reporter modules that
configure a reporter.
    See all tests where `MetricOptions.REPORTERS_LIST` was removed.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (docs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8080

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5099.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5099
    
----
commit 9516d60ffa87ff2d3a42ca0379e95ada0f42b61d
Author: zentol <chesnay@apache.org>
Date:   2017-11-15T11:56:30Z

    [FLINK-8080][metrics] Remove need for "metrics.reporters" config key

----


---

Mime
View raw message