flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] flinkbot edited a comment on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common
Date Fri, 01 Mar 2019 01:25:55 GMT
flinkbot edited a comment on issue #7848: [FLINK-10755][table] Port external catalogs in Table
API extension points to flink-table-common
URL: https://github.com/apache/flink/pull/7848#issuecomment-467855282
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help
the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Review Progress
   
   * ✅ 1. The [description] looks good.
       - Approved by @sunjincheng121 [committer]
   * ✅ 2. There is [consensus] that the contribution should go into to Flink.
       - Approved by @sunjincheng121 [committer]
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/reviewing-prs.html)
for a full explanation of the review process.<details>
     <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve the 1st aspect (similarly, it also supports
the `consensus`, `architecture` and `quality` keywords)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message