flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] carp84 commented on issue #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern
Date Fri, 01 Mar 2019 04:39:42 GMT
carp84 commented on issue #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend
follow the builder pattern
URL: https://github.com/apache/flink/pull/7866#issuecomment-468540097
 
 
   Note: now restore is included in backend building/constructing process, so we need to make
sure each stream constructed in restore could also be closed in case of task cancel, for example
the data input stream opened for (de)serialization during restore. This is exposed and noticed
in the failure of `InterruptSensitiveRestoreTest` w/ refactoring here.
   
   @StefanRRichter IMHO this is also a potential issue for the already done `RocksDBKeyedStateBackend`
refactoring, do you think we should make this change a separate PR and include it for 1.8
release? Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message