flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dawidwys commented on a change in pull request #7872: [FLINK-11420][core] Fixed duplicate method of TraversableSerializer
Date Fri, 01 Mar 2019 08:11:42 GMT
dawidwys commented on a change in pull request #7872: [FLINK-11420][core] Fixed duplicate method
of TraversableSerializer
URL: https://github.com/apache/flink/pull/7872#discussion_r261510127
 
 

 ##########
 File path: flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestInstance.java
 ##########
 @@ -62,19 +62,27 @@ protected int getLength() {
 	}
 	
 	// --------------------------------------------------------------------------------------------
-	
+
 	public void testAll() {
-		testInstantiate();
-		testGetLength();
-		testCopy();
-		testCopyIntoNewElements();
-		testCopyIntoReusedElements();
-		testSerializeIndividually();
-		testSerializeIndividuallyReusingValues();
-		testSerializeAsSequenceNoReuse();
-		testSerializeAsSequenceReusingValues();
-		testSerializedCopyIndividually();
-		testSerializedCopyAsSequence();
-		testSerializabilityAndEquals();
+		try {
 
 Review comment:
   I guess they were added later to the base class and the person that added those cases was
probably not aware of existence of this class.
   
   The try-catch is because a few of the new test cases throw exception, whereas the `testAll`
doesn't. Did not want to change it in every place where the `testAll` is called. I think though
in the long run we should revisit those places and actually get rid of this method at all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message