flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pnowojski edited a comment on issue #7604: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer
Date Fri, 01 Mar 2019 14:31:04 GMT
pnowojski edited a comment on issue #7604: [FLINK-11249] FlinkKafkaProducer011 can not be migrated
to FlinkKafkaProducer
URL: https://github.com/apache/flink/pull/7604#issuecomment-468682545
 
 
   There were couple of issues with the tests that you proposed @tvielgouarin. One of them
was that you were catching and ignoring the exception in your tests and this was hiding some
issues, while tests were "passing" (code from your tests was not being execute, since they
were failing very early on). There was also some code duplication that I removed. Please check
the PR that I have opened (it has some refactoring/clean ups):
   https://github.com/apache/flink/pull/7677
   
   The equivalent code to your PR is [this commit](
   https://github.com/apache/flink/pull/7677/commits/673e93a4104fd7bcb9f54275008cb2f90d81c692)
from my PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message