flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] StefanRRichter commented on a change in pull request #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
Date Mon, 11 Mar 2019 17:07:34 GMT
StefanRRichter commented on a change in pull request #7942: [FLINK-11696][checkpoint] Avoid
to send mkdir requests to DFS from task side
URL: https://github.com/apache/flink/pull/7942#discussion_r264335302
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStorage.java
 ##########
 @@ -107,6 +105,13 @@ public CheckpointStorageLocation initializeLocationForCheckpoint(long
checkpoint
 		// prepare all the paths needed for the checkpoints
 		final Path checkpointDir = createCheckpointDirectory(checkpointsDirectory, checkpointId);
 
+		if (!areDirectoriesCreated) {
+			fileSystem.mkdirs(checkpointsDirectory);
+			fileSystem.mkdirs(sharedStateDirectory);
 
 Review comment:
   Furthermore, I think we could also consider splitting the interface into one that is JM
side, owned by checkpoint coordinator and has the init lifecycle methods, and one that only
has the methods relevant for TM. Implementations inherit both, but his could shield TMs from
accidentally calling init methods. Would that make sense?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message