flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] StefanRRichter commented on a change in pull request #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side
Date Mon, 11 Mar 2019 17:57:16 GMT
StefanRRichter commented on a change in pull request #7942: [FLINK-11696][checkpoint] Avoid
to send mkdir requests to DFS from task side
URL: https://github.com/apache/flink/pull/7942#discussion_r264356853
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStorage.java
 ##########
 @@ -107,6 +105,13 @@ public CheckpointStorageLocation initializeLocationForCheckpoint(long
checkpoint
 		// prepare all the paths needed for the checkpoints
 		final Path checkpointDir = createCheckpointDirectory(checkpointsDirectory, checkpointId);
 
+		if (!areDirectoriesCreated) {
+			fileSystem.mkdirs(checkpointsDirectory);
+			fileSystem.mkdirs(sharedStateDirectory);
 
 Review comment:
   Yes, that sounds like a good split and would exactly help with that problem.
   The best way to handle this PR-wise would be:
   - create a JIRA for splitting the interface into something like and JM/TM side.
   - open PR for that change.
   - have this PR rebased, based on the interface split-PR.
   
   We should keep the cost/benefit ratio in mind. If you think rebasing would take you a lot
of time (I think it should not) then just do it in this PR. Otherwise, I suggest the above
strategy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message