flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on issue #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition
Date Tue, 12 Mar 2019 03:29:15 GMT
zhijiangW commented on issue #7911: [FLINK-11082][network] Fix the logic of getting backlog
in sub partition
URL: https://github.com/apache/flink/pull/7911#issuecomment-471841116
 
 
   @pnowojski , thanks for your reviews and suggestions!
   
   I would remove the second synchronized buffers during `getBuffersInBacklog`, so it would
bring any regression in theory.  I agree with we should verify this changes would make some
effects for certain scenarios. I would verify the current benchmark to confirm it. If no obvious
improvement, I could adjust the scenarios to fit this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message