flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] klion26 commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table
Date Tue, 12 Mar 2019 05:05:22 GMT
klion26 commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce
code generated typed sort to blink table
URL: https://github.com/apache/flink/pull/7958#discussion_r264522136
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/AbstractBinaryWriter.java
 ##########
 @@ -141,6 +141,16 @@ public void writeRow(int pos, BaseRow input, BaseRowSerializer serializer)
{
 		}
 	}
 
+	@Override
+	public void writeBinary(int pos, byte[] bytes) {
+		int len = bytes.length;
+		if (len <= 7) {
 
 Review comment:
   how about replacing the magic number with a variable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message