flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] tweise commented on issue #7896: [FLINK-9007] [kinesis] [e2e] Add Kinesis end-to-end test
Date Wed, 13 Mar 2019 15:31:30 GMT
tweise commented on issue #7896: [FLINK-9007] [kinesis] [e2e] Add Kinesis end-to-end test
URL: https://github.com/apache/flink/pull/7896#issuecomment-472473747
 
 
   @StefanRRichter thanks for taking a look.
   
   It's good to learn that we have an effort to provide a Java based e2e framework. It should
simplify new tests and make existing ones more maintainable.
   
   This Kinesis test was under discussion for a while and it is a current gap in coverage.
I would like to merge it and also backport it to 1.8.x. Happy to make changes to adopt the
new framework when it is ready, but we should not block on it.
   
   As for separating test logic and program, that's more or less already the case. The pipeline
code, the test driver and the Kinesis client (in the future "resource") live in separate classes.
Should be easy to port to the new framework when it is ready.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message