flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] sunjincheng121 commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow
Date Thu, 14 Mar 2019 10:56:48 GMT
sunjincheng121 commented on issue #7985: [FLINK-11918][table] Deprecated Window and Rename
it to GroupWindow
URL: https://github.com/apache/flink/pull/7985#issuecomment-472802257
 
 
   > Thank you @hequn8128.
   > 
   > What about `Tumble`, `Session`, `Slide`, and `Over` window? Do we also want to deprecate
`org.apache.flink.table.api.java.Tumble` and encourage `org.apache.flink.table.api.Tumble`?
   
   IMHO. It is important to correct the concept of `Window` to `GroupWindow`. The package
changes for these auxiliary methods can be kept in 1.9. Users seeing many classes with the
same name will be very confused´╝îsimilar to current `TableEnvironment`s.  So, I suggest removing
them directly in FLINK-11908.
   
   What do you think? @twalthr  @hequn8128 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message