flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lvhuyen commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet input format
Date Thu, 14 Mar 2019 11:19:40 GMT
lvhuyen commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet
input format
URL: https://github.com/apache/flink/pull/6483#discussion_r265520628
 
 

 ##########
 File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetPojoInputFormat.java
 ##########
 @@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.formats.parquet;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.java.typeutils.PojoTypeInfo;
+import org.apache.flink.core.fs.FileInputSplit;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.parquet.schema.MessageType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.lang.reflect.Field;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * A subclass of {@link ParquetInputFormat} to read from Parquets files and convert to POJO
type.
+ * It is mainly used to read simple data type without nested fields.
+ */
+public class ParquetPojoInputFormat<E> extends ParquetInputFormat<E> {
+
+	private static final Logger LOG = LoggerFactory.getLogger(ParquetPojoInputFormat.class);
+	private final Class<E> pojoTypeClass;
+	private final TypeSerializer<E> typeSerializer;
+	private transient Field[] pojoFields;
+
+	public ParquetPojoInputFormat(Path filePath, MessageType messageType, PojoTypeInfo<E>
pojoTypeInfo) {
+		super(filePath, messageType);
+		this.pojoTypeClass = pojoTypeInfo.getTypeClass();
+		this.typeSerializer = pojoTypeInfo.createSerializer(new ExecutionConfig());
+		final Map<String, Field> fieldMap = new HashMap<>();
+		findAllFields(pojoTypeClass, fieldMap);
+		selectFields(fieldMap.keySet().toArray(new String[fieldMap.size()]));
+	}
+
+	@Override
+	public void open(FileInputSplit split) throws IOException {
+		super.open(split);
+		pojoFields = new Field[getFieldNames().length];
+		LOG.error("Fields number is %d", getFieldNames().length);
 
 Review comment:
   Should this be LOG.debug?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message