flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wuchong commented on a change in pull request #7969: [FLINK-11896] [table-planner-blink] Introduce stream physical nodes
Date Thu, 14 Mar 2019 12:16:05 GMT
wuchong commented on a change in pull request #7969: [FLINK-11896] [table-planner-blink] Introduce
stream physical nodes
URL: https://github.com/apache/flink/pull/7969#discussion_r265496070
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/calcite/WatermarkAssigner.scala
 ##########
 @@ -32,21 +32,21 @@ import scala.collection.JavaConversions._
 abstract class WatermarkAssigner(
     cluster: RelOptCluster,
     traits: RelTraitSet,
-    inputNode: RelNode,
-    val rowtimeField: String,
-    val watermarkOffset: Long)
-  extends SingleRel(cluster, traits, inputNode) {
+    inputRel: RelNode,
+    val rowtimeFieldIndex: Option[Int],
+    val watermarkOffset: Option[Long])
 
 Review comment:
   Rename to watermarkDelay ?  In fact, it is the delay between max-timestamp and current
watermark.
   The offset terminology is usually means timezone offset in Flink. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message