flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wuchong commented on a change in pull request #7969: [FLINK-11896] [table-planner-blink] Introduce stream physical nodes
Date Thu, 14 Mar 2019 12:16:05 GMT
wuchong commented on a change in pull request #7969: [FLINK-11896] [table-planner-blink] Introduce
stream physical nodes
URL: https://github.com/apache/flink/pull/7969#discussion_r265500101
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/common/CommonJoin.scala
 ##########
 @@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.nodes.common
+
+import org.apache.flink.table.plan.FlinkJoinRelType
+import org.apache.flink.table.plan.nodes.physical.FlinkPhysicalRel
+import org.apache.flink.table.plan.util.{FlinkRelOptUtil, RelExplainUtil}
+
+import org.apache.calcite.rel.RelWriter
+import org.apache.calcite.rel.`type`.{RelDataType, RelDataTypeField}
+import org.apache.calcite.rel.core.{Join, SemiJoin}
+import org.apache.calcite.sql.validate.SqlValidatorUtil
+import org.apache.calcite.util.mapping.IntPair
+
+import java.util
+import java.util.Collections
+
+import scala.collection.JavaConversions._
+
+/**
+  * Base physical class for flink [[Join]].
+  */
+trait CommonJoin extends Join with FlinkPhysicalRel {
+
+  lazy val (joinInfo, filterNulls) = {
+    val filterNulls = new util.ArrayList[java.lang.Boolean]
+    val joinInfo = FlinkRelOptUtil.createJoinInfo(getLeft, getRight, getCondition, filterNulls)
+    (joinInfo, filterNulls.map(_.booleanValue()).toArray)
+  }
+
+  lazy val keyPairs: List[IntPair] = joinInfo.pairs.toList
+
+  // TODO supports FlinkJoinRelType.ANTI
+  lazy val flinkJoinType: FlinkJoinRelType = this match {
+    case sj: SemiJoin => FlinkJoinRelType.SEMI
+    case j: Join => FlinkJoinRelType.toFlinkJoinRelType(getJoinType)
+    case _ => throw new IllegalArgumentException(s"Illegal join node: ${this.getRelTypeName}")
+  }
+
+  lazy val inputRowType: RelDataType = this match {
+    case sj: SemiJoin =>
+      // Combines inputs' RowType, the result is different from SemiJoin's RowType.
+      SqlValidatorUtil.deriveJoinRowType(
+        sj.getLeft.getRowType,
+        sj.getRight.getRowType,
+        getJoinType,
+        sj.getCluster.getTypeFactory,
+        null,
+        Collections.emptyList[RelDataTypeField]
+      )
+    case j: Join => getRowType
+    case _ => throw new IllegalArgumentException(s"Illegal join node: ${this.getRelTypeName}")
+  }
+
+  override def explainTerms(pw: RelWriter): RelWriter = {
+    pw.input("left", getLeft).input("right", getRight)
+      .item("where",
+        RelExplainUtil.expressionToString(getCondition, inputRowType, getExpressionString))
+      .item("join", getRowType.getFieldNames.mkString(", "))
 
 Review comment:
   How about rename `join` to `select` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message