flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wuchong commented on a change in pull request #7969: [FLINK-11896] [table-planner-blink] Introduce stream physical nodes
Date Thu, 14 Mar 2019 12:16:05 GMT
wuchong commented on a change in pull request #7969: [FLINK-11896] [table-planner-blink] Introduce
stream physical nodes
URL: https://github.com/apache/flink/pull/7969#discussion_r265508645
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamExecRank.scala
 ##########
 @@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table.plan.nodes.physical.stream
+
+import org.apache.flink.table.plan.`trait`.TraitUtil
+import org.apache.flink.table.plan.nodes.calcite.{Rank, RankRange}
+import org.apache.flink.table.plan.util.{RelExplainUtil, UpdatingPlanChecker}
+
+import org.apache.calcite.plan.{RelOptCluster, RelTraitSet}
+import org.apache.calcite.rel._
+import org.apache.calcite.rel.`type`.RelDataType
+import org.apache.calcite.sql.SqlRankFunction
+import org.apache.calcite.util.ImmutableBitSet
+
+import java.util
+
+import scala.collection.JavaConversions._
+
+/**
+  * Stream physical RelNode for [[Rank]].
+  *
+  * @see [[StreamExecTemporalSort]] which must be time-ascending-order sort without `limit`.
+  * @see [[StreamExecSort]] which can be used for testing now, its sort key can be any type.
+  */
+class StreamExecRank(
+    cluster: RelOptCluster,
+    traitSet: RelTraitSet,
+    inputRel: RelNode,
+    rankFunction: SqlRankFunction,
+    partitionKey: ImmutableBitSet,
+    sortCollation: RelCollation,
+    rankRange: RankRange,
+    val outputRankFunColumn: Boolean)
+  extends Rank(
+    cluster,
+    traitSet,
+    inputRel,
+    rankFunction,
+    partitionKey,
+    sortCollation,
+    rankRange)
+  with StreamPhysicalRel {
+
+  /** please uses [[getStrategy]] instead of this field */
+  private var strategy: RankStrategy = _
+
+  def getStrategy(forceRecompute: Boolean = false): RankStrategy = {
+    if (strategy == null || forceRecompute) {
+      strategy = analyzeRankStrategy
+    }
+    strategy
+  }
+
+  override def producesUpdates = true
+
+  override def consumesRetractions = true
+
+  override def needsUpdatesAsRetraction(input: RelNode): Boolean = {
+    getStrategy(forceRecompute = true) == RetractRank
+  }
+
+  override def deriveRowType(): RelDataType = {
+    if (outputRankFunColumn) {
+      super.deriveRowType()
+    } else {
+      inputRel.getRowType
+    }
+  }
+
+  override def copy(traitSet: RelTraitSet, inputs: util.List[RelNode]): RelNode = {
+    new StreamExecRank(
+      cluster,
+      traitSet,
+      inputs.get(0),
+      rankFunction,
+      partitionKey,
+      sortCollation,
+      rankRange,
+      outputRankFunColumn)
+  }
+
+  override def explainTerms(pw: RelWriter): RelWriter = {
+    val inputRowType = inputRel.getRowType
+    pw.input("input", getInput)
+      .item("rankFunction", rankFunction.getKind)
+      .item("partitionBy", RelExplainUtil.fieldToString(partitionKey.toArray, inputRowType))
+      .item("orderBy", RelExplainUtil.collationToString(sortCollation, inputRowType))
+      .item("rankRange", rankRange.toString(inputRowType.getFieldNames))
+      .item("strategy", getStrategy())
 
 Review comment:
   I would suggest to move strategy before rankFunction as it is more important. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message