flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] sunjincheng121 edited a comment on issue #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow
Date Thu, 14 Mar 2019 12:46:08 GMT
sunjincheng121 edited a comment on issue #7985: [FLINK-11918][table] Deprecated Window and
Rename it to GroupWindow
URL: https://github.com/apache/flink/pull/7985#issuecomment-472834420
 
 
   Ooh, @twalthr, I got your points! I think we are on the same page about put the deprecated
APIs to 1.8 as soon as possible.
   
   I mainly concern is many classes with the same name will be very confused.  And in this
PR we deal with the concept of `Window`.  if we want to deal with the `Tumble`, `Session`
etc in this PR.  and merge into release-1.8,  then let API fully compatible, that's the correct
thing we should follow.  I agree with your proposal. 
   
   +1 from the points of my view.
   
   Best,
   Jincheng
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message