flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] HuangZhenQiu commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type
Date Thu, 14 Mar 2019 15:16:58 GMT
HuangZhenQiu commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable
yarn application type
URL: https://github.com/apache/flink/pull/7978#discussion_r265620892
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ##########
 @@ -468,6 +470,8 @@ private void validateClusterSpecification(ClusterSpecification clusterSpecificat
 			flinkConfiguration.setString(dynProperty.getKey(), dynProperty.getValue());
 		}
 
+		this.flinkVersion = dynProperties.getOrDefault("flink-version", "");
 
 Review comment:
   For most of the cases, we can get the precise version of flinkJarPath. But for some deployment
systems that submit jobs from customers, different jar will be used. Probably, using dynamic
properties can give more flexibility here. How do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message